Skip to content

Fixed javadoc issues preventing publication to Maven Central#119

Merged
rousso merged 1 commit intodevelopfrom
fix-javadoc-issues
Jun 2, 2025
Merged

Fixed javadoc issues preventing publication to Maven Central#119
rousso merged 1 commit intodevelopfrom
fix-javadoc-issues

Conversation

@rousso
Copy link
Copy Markdown
Contributor

@rousso rousso commented Jun 2, 2025

No description provided.

@rousso rousso requested a review from Copilot June 2, 2025 12:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses Javadoc issues that were preventing publication to Maven Central by enhancing documentation details in several Java files. Key changes include:

  • Adding Javadoc parameter documentation to the pushSibling method in ContentBlockStack.java.
  • Inserting generic type parameter descriptions for expression implementations in SequenceExpression.java, ScalarExpression.java, and PathExpression.java.
  • Updating Javadoc examples in MarkupGenerator.java for consistency and clarity.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ContentBlockStack.java Added Javadoc for the new "conditionals" parameter in the pushSibling method.
SequenceExpression.java Introduced generic parameter documentation for implementations.
ScalarExpression.java Added generic parameter documentation for the EFX data type.
PathExpression.java Added generic parameter documentation for the EFX data type.
MarkupGenerator.java Updated inline code and method reference documentation in the Javadoc comments.

Comment thread src/main/java/eu/europa/ted/efx/interfaces/MarkupGenerator.java
@rousso rousso merged commit de1f2e9 into develop Jun 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants